Consolidate tgis finetuning #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
… concept Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
…for evaluation Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
alex-jw-brooks
requested changes
Aug 7, 2023
| if not model_name_override.endswith(loaded_base_model): | ||
| raise ValueError( | ||
| log.error( |
There was a problem hiding this comment.
Why is this being made non fatal?
There was a problem hiding this comment.
This is because we are now re-training the models with fine-tuning, so model name may not be same as base_model name, os the above condition would fail.
examples/run_fine_tuning.py
Outdated
| try: | ||
| raw_model_text = model.run(datum.input).generated_text | ||
| except Exception as ex: | ||
| print(ex) |
There was a problem hiding this comment.
oof. Any way to make this more narrow, or is it like a general exception? Or, should we at least catch separately for in vs not in TGIS?
Co-authored-by: Alex Brooks <alex.brooks@ibm.com> Signed-off-by: Gaurav Kumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
gkumbhat
pushed a commit
to gkumbhat/caikit-nlp
that referenced
this pull request
Aug 24, 2023
Consolidate tgis finetuning Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #81
Changes
.trainfunction and related pre-processing function from fine-tuning modules to text-generation local module