fixed simple typo in run_fine_tuning.py #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Olson <joe.olson@ibm.com>
olson-ibm
requested review from
alex-jw-brooks,
gkumbhat and
evaline-ju
as code owners
|
Sorry for the confusion here. I'm still hazy on the proper procedure for signing commits. Do I have to have my ssh public key added to this repository? |
|
Nice work @olson-ibm , @gkumbhat / @alex-jw-brooks this issue is blocking me- could we get an expedited review? please and thank you. |
|
LGTM, thanks for the fix! I saw that you fixed the sign off, thanks @olson-ibm! IIRC signoff is tied to GPG keys. You shouldn't need to do anything specific for this repo, but you made need to get it set up for your account (which it seems like you may have already!) If you end up needing to go back and sign multiple commits in the future, you can do it with a |
alex-jw-brooks
approved these changes
Aug 14, 2023
Ssukriti
pushed a commit
to Ssukriti/caikit-nlp
that referenced
this pull request
Aug 24, 2023
Fix typo in run fine tuning Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com>
gkumbhat
pushed a commit
to gkumbhat/caikit-nlp
that referenced
this pull request
Aug 24, 2023
Fix typo in run fine tuning Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed simple typo in run_fine_tuning.py