Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eos_token bug fix #165

Merged
merged 1 commit into from
Sep 1, 2023
Merged

eos_token bug fix #165

merged 1 commit into from
Sep 1, 2023

Conversation

tharapalanivel
Copy link
Contributor

Allowing eos_token to be None

@tharapalanivel
🐛 Allow eos_token to be None
bbf1895 
Signed-off-by: Thara Palanivel <130496890+tharapalanivel@users.noreply.github.com>
@gkumbhat gkumbhat mentioned this pull request Sep 1, 2023
Open
@gkumbhat
Copy link
Collaborator

gkumbhat commented Sep 1, 2023

Tests to be added in this story

gkumbhat
gkumbhat approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@gkumbhat gkumbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Thara for the fix

@gkumbhat gkumbhat merged commit 841f446 into caikit:main Sep 1, 2023
4 checks passed
@tharapalanivel tharapalanivel deleted the eos_token_bug_fix branch September 13, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkumbhat gkumbhat gkumbhat approved these changes

@alex-jw-brooks alex-jw-brooks Awaiting requested review from alex-jw-brooks alex-jw-brooks is a code owner

@evaline-ju evaline-ju Awaiting requested review from evaline-ju evaline-ju is a code owner

@gabe-l-hart gabe-l-hart Awaiting requested review from gabe-l-hart gabe-l-hart is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tharapalanivel @gkumbhat