Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚚 Change parameter name and mark them optional for runtime #173

Merged
merged 3 commits into from
Sep 7, 2023
Merged

🚚 Change parameter name and mark them optional for runtime #173

merged 3 commits into from
Sep 7, 2023

Conversation

gkumbhat
Copy link
Collaborator

@gkumbhat gkumbhat commented Sep 5, 2023 •
edited

Changes

  • Change lr to learning_rate to make it more intuitive
  • Mark training parameter with default as optional via type annotation for the correct runtime service generation.

@gkumbhat
🚚 Change parameter name and mark them optional for runtime
39ae73d 
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
@gkumbhat
🔧 Make val stream optional
f1a9698 
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
@gkumbhat
🎨 Fix formatting
f7b68a7 
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
@gkumbhat gkumbhat marked this pull request as ready for review September 5, 2023 19:45
alex-jw-brooks
alex-jw-brooks approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@alex-jw-brooks alex-jw-brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - aside from being more correct type hints, does the lack of optionals here break runtime train jobs if they're not set? I need to learn more about the way type hints are leveraged by it 😄

@gkumbhat
Copy link
Collaborator Author

gkumbhat commented Sep 7, 2023

Thanks @alex-jw-brooks . It doesn't break, just doesn't show up as optional so adds confusion

@gkumbhat gkumbhat merged commit c16c33a into caikit:main Sep 7, 2023
4 checks passed
@gkumbhat gkumbhat deleted the change_param_name branch September 7, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-jw-brooks alex-jw-brooks alex-jw-brooks approved these changes

@evaline-ju evaline-ju Awaiting requested review from evaline-ju evaline-ju is a code owner

@gabe-l-hart gabe-l-hart Awaiting requested review from gabe-l-hart gabe-l-hart is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gkumbhat @alex-jw-brooks