Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥅 Allow int thresholds #336

Merged
merged 2 commits into from
Mar 13, 2024
Merged

🥅 Allow int thresholds #336

merged 2 commits into from
Mar 13, 2024

Conversation

evaline-ju
Copy link
Collaborator

Add more flexibility to thresholds to include ints

Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
@evaline-ju
Copy link
Collaborator Author

Lint here could wait on input_token_count use in #334

Copy link
Collaborator

@gkumbhat gkumbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending the linting fix that Evaline commented, we can merge later on.

@evaline-ju
Copy link
Collaborator Author

Merged main in after #334 and lint passing now, merging

@evaline-ju evaline-ju merged commit f55b082 into caikit:main Mar 13, 2024
5 checks passed
@evaline-ju evaline-ju deleted the int-threshold branch March 13, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants