-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Bytes Json Schema to base64 #462
Conversation
This is awesome, thanks @HonakerM ! Yeah we can wait for the official release! |
@HonakerM I tried to resolve the conflicts, but apparently my mental |
8602b43
to
5390f9e
Compare
@HonakerM It looks like the test failures are legitimate (I was distracted by the warning about the invalid escape sequence). If this is still important, can you look into getting those fixed? |
@gabe-l-hart Okay I'll take a look! This change isn't the most pressing so I'm not sure when I'll get to it but it'd probably be nice to have. |
@HonakerM Do you still need this one? It looks like it could use a rebase and some test fixes if so |
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
5390f9e
to
7950164
Compare
@gabe-l-hart it's not required but would be nice. I just rebased/updated version, I'll keep an eye out for test failures |
Closing as stale. @HonakerM we can revisit later if this becomes urgent |
What this PR does / why we need it:
This PR sets the pydantic bytes json schema to
base64
. This updates the auto-generated openapi docs to correctly listbytes
fields asbase64
formatted strings instead of rawbinary
strings.Special notes for your reviewer:
I discovered this config while exploring the pydantic repo. The PR that created the config was only merged last week so it hasn't been released. I tested my changes with a local clone of pydantic and
ConfigDict
is backwards compatible so this should be safe to merge but for abundance of caution this PR can wait until an official version is released.If applicable: