Multitask train modules 707 #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty The use of set was causing lots of problems since sets do not guarantee consistent order. It was there to ensure uniqueness which we'll tackle in the creation of _TASK_CLASSES directly. caikit#707 Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
caikit#707 Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
…roperty caikit#707 Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
gabe-l-hart
requested review from
joerunde,
prashantgupta24,
gkumbhat,
hickeyma,
evaline-ju,
alex-jw-brooks,
tharapalanivel and
aluu317
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Closes #707
This PR updates the logic for how the
ModuleClass.tasksproperty is implemented. The previous use of asetwas there to ensure uniqueness. It also had the subtle implication that all tasks are equally important to a givenModuleClasssince asetdoes not guarantee order.This second implication, however, was not respected in the train API generation. Since a given
ModuleClasscan have only a singletrainmethod, the mapping fromModuleClasstotaskwas nondeterministic for multitask module training. With this PR, the order oftasksis now strictly defined to be the unique concatenation of the list of tasks in the module itself with the task lists of all parent modules in MRO.Special notes for your reviewer:
If applicable: