Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📌 Disallow grpcio 1.64.0 for abstract method regression #720

Merged
merged 1 commit into from
May 22, 2024

Conversation

evaline-ju
Copy link
Collaborator

What this PR does / why we need it:

For: grpc/grpc#36683 - after applications using caikit got bumped to the latest version of grpcio (1.64.0) due to the flexible version range, errors were seen/builds were broken

This assumes that 1.64.0 will be the only problematic version and any next release will contain a fix for the issue

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Copy link
Contributor

@prashantgupta24 prashantgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@evaline-ju evaline-ju merged commit f5ec099 into caikit:main May 22, 2024
8 checks passed
@evaline-ju evaline-ju deleted the grpcio-pin branch May 22, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants