-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ireland regions #22
Conversation
@@ -35,6 +35,7 @@ class UnknownAttribute < ArgumentError; end | |||
:locality => :city, | |||
:state => :region, | |||
:province => :region, | |||
:county => :region, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! But would this mean that the term county is ambiguous? It's definitely not equivalent to state and province in the US.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this aliasing may not be necessary, but Irish counties are used equivalently to US states in mailing addresses and US counties aren't really used in mailing addresses, so I threw it in there.
open to pulling that part out though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://www.upu.int/fileadmin/documentsFiles/activities/addressingUnit/irlEn.pdf
^ format for irish mailing addresses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
US counties aren't really used in mailing addresses
hmm, that's a good point. it may work out in practice? but let's try deferring on this alias -- it could be difficult to undo in future versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool donezo.
released in |
Enumerating the regions for Ireland. They aren't typically abbreviated, so string names are just mapped to string names in the
REGIONS
hash.Also including
county
as a synonym for region since that's how Ireland does it.