Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ireland regions #22

Merged
merged 2 commits into from
Jan 22, 2015
Merged

Add Ireland regions #22

merged 2 commits into from
Jan 22, 2015

Conversation

swoopej
Copy link
Contributor

@swoopej swoopej commented Jan 22, 2015

Enumerating the regions for Ireland. They aren't typically abbreviated, so string names are just mapped to string names in the REGIONS hash.

Also including county as a synonym for region since that's how Ireland does it.

@@ -35,6 +35,7 @@ class UnknownAttribute < ArgumentError; end
:locality => :city,
:state => :region,
:province => :region,
:county => :region,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! But would this mean that the term county is ambiguous? It's definitely not equivalent to state and province in the US.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this aliasing may not be necessary, but Irish counties are used equivalently to US states in mailing addresses and US counties aren't really used in mailing addresses, so I threw it in there.

open to pulling that part out though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

US counties aren't really used in mailing addresses

hmm, that's a good point. it may work out in practice? but let's try deferring on this alias -- it could be difficult to undo in future versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool donezo.

cainlevy added a commit that referenced this pull request Jan 22, 2015
@cainlevy cainlevy merged commit 88e4c94 into cainlevy:master Jan 22, 2015
@cainlevy
Copy link
Owner

released in 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants