Skip to content

Commit

Permalink
kill the /lib dir and move classes to the top level, simplifying
Browse files Browse the repository at this point in the history
organization.
use istanbul instead of jscoverage
version bump 0.7 (these versions are not related to kafka versions)
  • Loading branch information
cainus committed May 5, 2014
1 parent 6560d36 commit 2c155bf
Show file tree
Hide file tree
Showing 20 changed files with 46 additions and 43 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ node_modules
npm-debug.log npm-debug.log
.DS_Store .DS_Store
coverage.html coverage.html
coverage
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion lib/Consumer.js → Consumer.js
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var OffsetsResponse = require('./OffsetsResponse');
var FetchRequest = require('./FetchRequest'); var FetchRequest = require('./FetchRequest');
var OffsetsRequest = require('./OffsetsRequest'); var OffsetsRequest = require('./OffsetsRequest');
var FetchResponse = require('./FetchResponse'); var FetchResponse = require('./FetchResponse');
var Response = require('../lib/Response'); var Response = require('./Response');


var Consumer = function(options){ var Consumer = function(options){
this.MAX_MESSAGE_SIZE = 1024 * 1024; // 1 megabyte this.MAX_MESSAGE_SIZE = 1024 * 1024; // 1 megabyte
Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions lib/FetchResponse.js → FetchResponse.js
Original file line number Original file line Diff line number Diff line change
@@ -1,7 +1,7 @@
var binary = require('binary'); var binary = require('binary');
var BufferMaker = require('buffermaker'); var BufferMaker = require('buffermaker');
var Message = require('../lib/Message'); var Message = require('./Message');
var Response = require('../lib/Response'); var Response = require('./Response');
var _ = require('underscore'); var _ = require('underscore');


/* HEADER /* HEADER
Expand Down
31 changes: 16 additions & 15 deletions Makefile
Original file line number Original file line Diff line number Diff line change
@@ -1,21 +1,22 @@
REPORTER = dot test:
test: npm-install @NODE_ENV=test ./node_modules/.bin/mocha --timeout 30000
@NODE_ENV=test ./node_modules/.bin/mocha --reporter $(REPORTER)


lib-cov:
jscoverage lib lib-cov


test-cov: lib-cov lint:
@PROZESS_COVERAGE=1 $(MAKE) test REPORTER=html-cov > coverage.html ./node_modules/.bin/jshint ./test ./index.js
rm -rf lib-cov


test-coveralls: lib-cov test-cov:
$(MAKE) test REPORTER=spec $(MAKE) lint
@NODE_ENV=test ./node_modules/.bin/istanbul cover \
./node_modules/mocha/bin/_mocha -- -R spec

test-coveralls:
echo TRAVIS_JOB_ID $(TRAVIS_JOB_ID) echo TRAVIS_JOB_ID $(TRAVIS_JOB_ID)
@PROZESS_COVERAGE=1 $(MAKE) test REPORTER=json-cov 2> /dev/null | ./node_modules/coveralls/bin/coveralls.js $(MAKE) test
rm -rf lib-cov @NODE_ENV=test ./node_modules/.bin/istanbul cover \
./node_modules/mocha/bin/_mocha --report lcovonly -- -R spec && \
cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js || true



npm-install:
npm install


.PHONY: test .PHONY: test
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions lib/ProduceRequest.js → ProduceRequest.js
Original file line number Original file line Diff line number Diff line change
@@ -1,6 +1,6 @@
var BufferMaker = require('buffermaker'); var BufferMaker = require('buffermaker');
var Message = require('../lib/Message'); var Message = require('./Message');
var Request = require('../lib/Request'); var Request = require('./Request');
var _ = require('underscore'); var _ = require('underscore');
var binary = require('binary'); var binary = require('binary');
var assert = require('assert'); var assert = require('assert');
Expand Down
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion lib/Response.js → Response.js
Original file line number Original file line Diff line number Diff line change
@@ -1,6 +1,6 @@
var binary = require('binary'); var binary = require('binary');
var BufferMaker = require('buffermaker'); var BufferMaker = require('buffermaker');
var Message = require('../lib/Message'); var Message = require('./Message');
var _ = require('underscore'); var _ = require('underscore');
var assert = require('assert'); var assert = require('assert');


Expand Down
2 changes: 1 addition & 1 deletion consume_test.js
Original file line number Original file line Diff line number Diff line change
@@ -1,4 +1,4 @@
var Consumer = require('./lib/Consumer'); var Consumer = require('./Consumer');


var options = {host : 'localhost', topic : 'social', partition : 0, offset : 0}; var options = {host : 'localhost', topic : 'social', partition : 0, offset : 0};
var consumer = new Consumer(options); var consumer = new Consumer(options);
Expand Down
24 changes: 10 additions & 14 deletions index.js
Original file line number Original file line Diff line number Diff line change
@@ -1,14 +1,10 @@
var dir = './lib/'; exports.Producer = require('./Producer');
if (process.env.PROZESS_COVERAGE){ exports.Consumer = require('./Consumer');
var dir = './lib-cov/'; exports.Message = require('./Message');
} exports.FetchRequest = require('./FetchRequest');
exports.Producer = require(dir + 'Producer'); exports.ProduceRequest = require('./ProduceRequest');
exports.Consumer = require(dir + 'Consumer'); exports.Request = require('./Request');
exports.Message = require(dir + 'Message'); exports.Response = require('./Response');
exports.FetchRequest = require(dir + 'FetchRequest'); exports.FetchResponse = require('./FetchResponse');
exports.ProduceRequest = require(dir + 'ProduceRequest'); exports.OffsetsResponse = require('./OffsetsResponse');
exports.Request = require(dir + 'Request'); exports.OffsetsRequest = require('./OffsetsRequest');
exports.Response = require(dir + 'Response');
exports.FetchResponse = require(dir + 'FetchResponse');
exports.OffsetsResponse = require(dir + 'OffsetsResponse');
exports.OffsetsRequest = require(dir + 'OffsetsRequest');
13 changes: 9 additions & 4 deletions package.json
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"producer", "producer",
"consumer" "consumer"
], ],
"version": "0.6.4", "version": "0.7.0",
"bugs": { "bugs": {
"url": "https://github.com/cainus/Prozess/issues" "url": "https://github.com/cainus/Prozess/issues"
}, },
Expand All @@ -30,7 +30,11 @@
"crc32": "0.2.2", "crc32": "0.2.2",
"buffer-crc32": "0.2.1", "buffer-crc32": "0.2.1",
"bignum": "0.6.2", "bignum": "0.6.2",
"readable-stream": "1.0.26" "readable-stream": "1.0.26",
"istanbul": "^0.2.8",
"mocha": "^1.18.2",
"jshint": "^2.5.0",
"coveralls": "^2.10.0"
}, },
"devDependencies": { "devDependencies": {
"jscoverage": "0.3.6", "jscoverage": "0.3.6",
Expand All @@ -52,6 +56,7 @@
"engines": { "engines": {
"node": ">=0.8.0" "node": ">=0.8.0"
}, },
"author": "", "author": "Gregg Caines",
"license": "BSD" "license": "BSD",
"homepage": "https://github.com/cainus/Prozess"
} }
4 changes: 2 additions & 2 deletions produce_test.js
Original file line number Original file line Diff line number Diff line change
@@ -1,7 +1,7 @@
var Producer = require('./lib/Producer'); var Producer = require('./Producer');


var producer = new Producer('social', {host : 'localhost'}); var producer = new Producer('social', {host : 'localhost'});
producer.connect() producer.connect();
producer.on('error', function(err){ producer.on('error', function(err){
console.log("error: ", err); console.log("error: ", err);
}); });
Expand Down
2 changes: 1 addition & 1 deletion test/Producer.js
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ var BufferMaker = require('buffermaker');
var binary = require('binary'); var binary = require('binary');
var net = require('net'); var net = require('net');
var EventEmitter = require('events').EventEmitter; var EventEmitter = require('events').EventEmitter;
var sinon = require('../lib/sinonPatch'); var sinon = require('./lib/sinonPatch');


function closeServer(server, cb){ function closeServer(server, cb){
var called = false; var called = false;
Expand Down
File renamed without changes.

0 comments on commit 2c155bf

Please sign in to comment.