Connection cache for producer #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,7 @@ | |||
| "producer", | |||
| "consumer" | |||
| ], | |||
| "version": "0.6.4", | |||
| "version": "0.6.5", | |||
There was a problem hiding this comment.
please remove the commit that bumps the version from this public pull request.
|
See newer #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally globally cache connections to a host:port.
Connecting/reconnecting was broken into a separate Connection object. This is what is cached. Many Producers can share one Connection. The original event generation behavior was preserved.
The producer test runs twice, with and without caching. New tests were added with a mock socket to test edge cases.