Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CircleCI commenting on PRs #90

Merged
merged 2 commits into from
Dec 10, 2015

Conversation

saponifi3d
Copy link

This adds support for node-coveralls to post the service_pull_request for CircleCI.

  • Unfortunately they don't have an environment variable that is the PR number itself, so there is minor string manipulation to get it working.

Josh Callender added 2 commits April 24, 2015 12:00
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.41%) to 95.26% when pulling fba9005 on saponifi3d:circle-pr-support into d5e1372 on cainus:master.

@saponifi3d
Copy link
Author

FYI - there is something funky in the test harness, it's failing because travis is setting the env variable?

@dougmoscrop
Copy link

Any progress on this? We'd really like to use coveralls with CirlceCI.

@saponifi3d
Copy link
Author

I'm just using this fork for now. Works great, the rest failure is a weird env variable that breaks on travis.

@nickmerwin nickmerwin merged commit fba9005 into nickmerwin:master Dec 10, 2015
@nickmerwin
Copy link
Owner

Thank you @saponifi3d !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants