Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive max_transmissions #6

Closed
jeromegn opened this issue Apr 18, 2022 · 3 comments · Fixed by #7
Closed

Adaptive max_transmissions #6

jeromegn opened this issue Apr 18, 2022 · 3 comments · Fixed by #7

Comments

@jeromegn
Copy link

Determining the value for max_transmissions should be dynamic based on the number of members. Probably based on the memberlist implementation!

Or it should be possible to update this value at runtime as more members are added to a cluster.

Currently I'm passing a NODE_COUNT env var (for now I know this before deploying anything) and using the formula from memberlist.

@caio
Copy link
Owner

caio commented Apr 19, 2022

Agreed! I like the simplicity of a static config but it makes sense to adapt based on current size; suspect_to_down_after probably needs to adapt too. Gonna give it some thought and get to it come next free time

@caio
Copy link
Owner

caio commented May 28, 2022

Took me a very long while to circle back here, apologies.

I'll be merging #7 for this today; I went for allowing to change settings at runtime instead of pulling the whole logic into Foca (a little more detail in the PR)

I think what's more interesting for your scenario of broadcasting custom data to a subset of the cluster would be (A) the ability to control the broadcast retransmission independently from the swim parameters; and (B) the ability to ask foca to broadcast to every member it can broadcast to at once. Both pretty easy to do once #7 lands- HMU if that's something you'd be keen on checking!

@caio caio closed this as completed in #7 May 29, 2022
@jeromegn
Copy link
Author

jeromegn commented May 30, 2022

I'll have to update our crate, but looks like it should work! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants