Allow changing configuration at runtime via Foca::set_config #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch simply moves `max_transmissions` outside of `Broadcast`, so that the number of transmissions can be defined at runtime
This patch introduces `Config::new_lan` and `Config::new_wan` methods to derive configurations that should work well in their parciular network environment. Settings are a direct port from hashicorp's memberlist, mistakes are mine.
This patch introduces `Foca::set_config` which allows changing (some) configuration parameters while Foca is running and swimming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches expose a new method
Foca::set_configto allow tuning parameters at runtime, preserving the known cluster state and the current identity.Additionally, if the
stdfeature is set, two helpers are exposed to help create a config:Config::new_wanandConfig::new_lan.I didn't feel comfortable bringing in the whole dynamic configuration logic into Foca because:
Foca::num_members+Foca::set_configcore_instrinsics(or jump into libm / another dep) for math onno_stdMight revisit this decision in the future if I ever buy into lifeguard/awareness
Resolves #6