Correctly report uncaught error outcomes #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhanlon22
commented
Aug 30, 2020
| (when (= type :step-end) | ||
| (run! ctest/do-report reports)) | ||
| (when (= outcome :error) | ||
| (ctest/report {:type :error |
There was a problem hiding this comment.
The failed step doesn't contain the actual exception, which is why I used report instead of do-report. I created an issue to track adding the actual exception to the event: amperity/greenlight#50
There was a problem hiding this comment.
Created a PR to add this functionality: amperity/greenlight#51
robhanlon22
force-pushed
the
fix-error-output
branch
from
6616e43
to
ba858f6
Compare
|
Closing because amperity/greenlight#51 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a test that had an exception outside of an assertion would appear to have passed. This handles the uncaught errors correctly. However, if/when amperity/greenlight#51 lands, this change should be reverted, as it's a workaround that should be handled correctly over in greenlight.
Builds on the fixes in #8.