Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GNU Screen bullet #227

Merged
merged 4 commits into from Oct 10, 2017
Merged

Add GNU Screen bullet #227

merged 4 commits into from Oct 10, 2017

Conversation

KuhlTime
Copy link
Contributor

bildschirmfoto 2017-06-26 um 01 44 35

This prompt should help you keep track of the current screen session you're currently working in.

For those who may don't know screen. It's a window manager developed by GNU, which makes it easy to create individual terminal sessions. Often used on servers, in case you lose your ssh connection, you can easily restore to your terminal.
http://www.gnu.org/software/screen/

This is my first pull request, in case I did anything wrong please let me know. 🙂

@KuhlTime
Add screen prompt
a7293eb 
Add a new bullet showing the current screen session.

GNU Screen is a easy to use window manager.
For more information visit: http://www.gnu.org/software/screen/
@KuhlTime
Add screen information to README
180e964
@vadviktor
Copy link
Collaborator

First of all I am sorry for getting back to you so late.
I gave it a try, the prompt showing up right expect for it's cog glyph. I am sure you are using Mac and maybe iTerm2, that has superior rendering. I am using a Linux distro with highly sophisticated terminals (fonts even) and none is able to show/render that UTF-8 glyph, not even my text editor.

Could you replace it with something from this site, please? https://unicode-table.com/en/
Also if you have found the one you like, please link it back here so I can double check for you that it renders correctly :)

Soon that is working I will merge this PR.

@vadviktor vadviktor self-requested a review July 28, 2017 07:29
@vadviktor vadviktor self-assigned this Jul 28, 2017
vadviktor
vadviktor requested changes Jul 28, 2017
View reviewed changes
Copy link
Collaborator

@vadviktor vadviktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's find a utf-8 glyph that works on Linux too, please.

@KuhlTime
Copy link
Contributor Author

Now I'm really sorry that it took me so long to change this simple icon.
I have chosen this "⬗" prefix, which I have tested on Kali. Even though feel free to change it if you don't like it.

vadviktor
vadviktor requested changes Oct 10, 2017
View reviewed changes
README.md Outdated
|--------|-------|-------|
|`BULLETTRAIN_SCREEN_BG`|`white`|Background color
|`BULLETTRAIN_SCREEN_FG`|`black`|Foreground color
|`BULLETTRAIN_SCREEN_PREFIX`|`⚙`|Prefix of the segment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation was not updated with the new icon. Please fix.

@vadviktor vadviktor merged commit e564ca0 into caiogondim:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadviktor vadviktor vadviktor approved these changes

Assignees

@vadviktor vadviktor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KuhlTime @vadviktor