Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with org-wiki-paste-image #8

Closed
schuach opened this issue Dec 15, 2016 · 2 comments
Closed

Issue with org-wiki-paste-image #8

schuach opened this issue Dec 15, 2016 · 2 comments

Comments

@schuach
Copy link

schuach commented Dec 15, 2016

First I have to say that I like your package very much! I hope to see it on MELPA soon.

I've been experiencing issues with org-wiki-paste-image . I always have to enter the whole path to the file, because in helm not the org-wiki-location but the location of my emacs-binaries is prepended to dir. For example when I try to paste an image to index.org, the helm-promt for the filename looks like this:
wrong_path

I do think I have a fix though. It works for me, but I am not a programmer, so I can't tell if it's a very good one: The docstring of read-file-name says, that one should provide an absolute directory name for DIR. In line 793 of org-wiki.el, dir is only passed the name of the directory, not the whole path. I have modified the line to:

   `(file (read-file-name "Image: " (concat org-wiki-location "/" dir))))`

Now read-file-name sees the full directory name and it works for me.

Would it make sense for you to make that change to org-wiki.el?

Thanks and best regards,
Stefan

caiorss added a commit that referenced this issue Dec 23, 2016
 - Issue: #8 - Issue with org-wiki-paste-image - #8
@caiorss
Copy link
Owner

caiorss commented Dec 23, 2016

Ok. I've fixed it. Check out this new release. Thanks for the bug report.

@schuach
Copy link
Author

schuach commented Dec 24, 2016

Work fine now, thank you!

@schuach schuach closed this as completed Dec 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants