Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable open multiple CairoSettingsWindow.xaml #293

Closed
Brummell67 opened this issue Jan 9, 2020 · 9 comments
Closed

Disable open multiple CairoSettingsWindow.xaml #293

Brummell67 opened this issue Jan 9, 2020 · 9 comments

Comments

@Brummell67
Copy link
Contributor

As the title suggests,it is not disturbing to be able to have the same window open several times at the same time?
What do you think?

@josuave
Copy link
Collaborator

josuave commented Jan 9, 2020

Wouldn’t hurt to have settings be single instance. Where if a second instance is requested the current would come to the foreground. Brummell67 is this something that you would like to tackle? If not, I will add this functionality.

@Brummell67
Copy link
Contributor Author

Brummell67 commented Jan 9, 2020

Brummell67 is this something that you would like to tackle?

Sure, with pleasure.

@josuave
Copy link
Collaborator

josuave commented Jan 9, 2020

Nice, i have looked at the source on here and have thought of a good solution. Very interested to see what you bring.

@Brummell67
Copy link
Contributor Author

Brummell67 commented Jan 9, 2020

Nice, i have looked at the source on here and have thought of a good solution. Very interested to see what you bring.

Wait please.
I don't know still how to relationing in this ambient, sorry.
In cases like this what is better/correct way?
Can we reason together before write code?
Maybe your idea is better of my.
Thank you

@Brummell67
Copy link
Contributor Author

I'm ready. I wait your answer.

@josuave
Copy link
Collaborator

josuave commented Jan 11, 2020

I think the best way, is for you to make an attempt in your fork. Once you have committed it to your branch,let me know. I can then review it with you and we can discuss from there.

@Brummell67
Copy link
Contributor Author

Thank for your replay.
I've another push in review:
"Possibility to choose for autorun at login #290"
Can I push also this now?

@josuave
Copy link
Collaborator

josuave commented Jan 11, 2020

Ah, i forgot about the previous PR.

@Brummell67
Copy link
Contributor Author

I should be ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants