Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task is Successful even if Git is Unavailable #41

Open
mikeborozdin opened this issue May 26, 2014 · 1 comment
Open

Task is Successful even if Git is Unavailable #41

mikeborozdin opened this issue May 26, 2014 · 1 comment

Comments

@mikeborozdin
Copy link

This seems to be a bug that can mislead users, because they will think that a release has been successful, while no code has been pushed to Git.

Steps to reproduce

  1. Add an intentionally wrong Git endpoint to Gruntfile.js
  2. Run grunt bowerInstall

Expected Behaviour

  1. The bower task must fail
  2. It must notify that the Git endpoint is not available

Actual Behaviour

  1. The task succeeds
  2. It says Done, without errors.

Additional Information

You can clearly see that the released has failed if you run grunt bowerRelease --v which say something like:

fatal: Not a git repository (or any of the parent directories): .git

Done, without errors.

Solution

Unless there is already a patch for that, I'm going to submit a pull request shortly.

@mikeborozdin
Copy link
Author

Hi @caitp,

I have submitted a pull request for this issue - #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant