-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lcov-result-merger package update to 3.x #43
Conversation
Well, travis testing is broken, but it looks like the only changes between versions are package.json changes, mostly about the tool's internal dependencies... So it's probably fine. Have you tried this out locally to verify that it's working? |
Update travis CI builder to also run node 10
cd8fac2
to
ecf1eeb
Compare
@webdevbyjoss just re-asking.. I was just hoping for a quick yes/no answer before merging :) |
@caitp of course. Just wanted to make sure it works, so configured Travis build on my fork and it passes: Also tested the version with my app's unit tests in a private repo and it works as expected Looks like we are good to merge. |
Should fix the #42 |
hey, I've merged your changes and bumped to v2.0.0, which has been published. Don't hesitate to file a new bug if there are more issues with it. |
Updated lcov-result-merger package to 3.x which is compatible with Node v10
This PR fixes #42