Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcov-result-merger package update to 3.x #43

Closed
wants to merge 7 commits into from

Conversation

webdevbyjoss
Copy link
Contributor

@webdevbyjoss webdevbyjoss commented Jul 4, 2018

Updated lcov-result-merger package to 3.x which is compatible with Node v10

This PR fixes #42

@webdevbyjoss webdevbyjoss changed the title Updated lcov-result-merger package to 3.x which is compatible with Node v10 lcov-result-merger package update to 3.x Jul 4, 2018
@caitp
Copy link
Owner

caitp commented Jul 4, 2018

Well, travis testing is broken, but it looks like the only changes between versions are package.json changes, mostly about the tool's internal dependencies... So it's probably fine.

Have you tried this out locally to verify that it's working?

@caitp
Copy link
Owner

caitp commented Jul 6, 2018

@webdevbyjoss just re-asking.. I was just hoping for a quick yes/no answer before merging :)

@webdevbyjoss
Copy link
Contributor Author

@caitp of course. Just wanted to make sure it works, so configured Travis build on my fork and it passes:
https://travis-ci.org/webdevbyjoss/karma-coveralls
screen shot 2018-07-06 at 11 09 50 am

on both NodeJS v8 and v10
screen shot 2018-07-06 at 11 10 13 am

Also tested the version with my app's unit tests in a private repo and it works as expected
screen shot 2018-07-05 at 1 37 52 pm

Looks like we are good to merge.

@webdevbyjoss
Copy link
Contributor Author

webdevbyjoss commented Jul 6, 2018

Should fix the #42

@caitp caitp closed this in fb19885 Jul 6, 2018
@caitp
Copy link
Owner

caitp commented Jul 6, 2018

hey, I've merged your changes and bumped to v2.0.0, which has been published.

Don't hesitate to file a new bug if there are more issues with it.

@webdevbyjoss webdevbyjoss deleted the fix-node-v10-issue-42 branch July 7, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to install on latest NodeJS v10
2 participants