Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collation conflict #18

Merged
merged 2 commits into from Mar 22, 2024
Merged

Fix collation conflict #18

merged 2 commits into from Mar 22, 2024

Conversation

simelis
Copy link
Contributor

@simelis simelis commented Feb 27, 2024

The QueryDBTableSchema* queries result in the following exception when my db and temp db collations do not match:
Cannot resolve the collation conflict between "tempdb_collation" and "my_db_colletion" in the equal to operation.

This fixes the error. I didn't test with temp tables though.

@cajuncoding
Copy link
Owner

@simelis Interesting…Thanks for the PR! 👍

I’ll run the integration tests to confirm everything is consistent!

Copy link
Owner

@cajuncoding cajuncoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look Good, and all integration tests pass on the first run!

PR Approved ✅

Thanks for the Contribution to make this better for everyone 🙏

@cajuncoding cajuncoding merged commit c2a57ab into cajuncoding:main Mar 22, 2024
1 check passed
@cajuncoding
Copy link
Owner

Integration Tests look good ✅
image

@cajuncoding
Copy link
Owner

Now available in v2.4.4 on Nuget: https://www.nuget.org/packages/SqlBulkHelpers/2.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants