Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rider 2023.1 #325

Closed
asidorowicz opened this issue Apr 6, 2023 · 9 comments · Fixed by #351
Closed

Upgrade to Rider 2023.1 #325

asidorowicz opened this issue Apr 6, 2023 · 9 comments · Fixed by #351
Milestone

Comments

@asidorowicz
Copy link

Love the plugin, however it does not work with the latest version of Rider
I tried editing the jar to force it to load, and it does. The settings menu hangs however, so it might require a little work.
The tasks do run though, and the rest seems to work well

@sebastienpa
Copy link

+1

@nils-a nils-a modified the milestones: vNext, 6.0.0 Apr 28, 2023
@baynezy
Copy link

baynezy commented May 23, 2023

Any update on how this is going?

@evhenii-komar
Copy link

Still waiting on it.

@LoveDuckie
Copy link

I wish it was possible to +1 react to a comment, so I apologise for how asinine this comment is! 😄

I also love the plugin and waiting for the 2023 support. Going to roll my sleeves up and take a look and what's required for the fix and if there's any breaking API change.

@nils-a
Copy link
Member

nils-a commented Aug 22, 2023

@LoveDuckie there are some minor breaking changes, nothing serious though.
The main obstacle currently is the settings pages crashing when the settings are opening.
So far I have somehow been unable to get a handle on that.

nils-a added a commit to nils-a/cake-rider that referenced this issue Aug 23, 2023
nils-a added a commit to nils-a/cake-rider that referenced this issue Aug 23, 2023
This is probably due to the change in UI on the intellij-side.
It seems the builtin add/remove icons were removed and replaced by new
ones. These needed a different kind of "loading".
@nils-a nils-a linked a pull request Aug 23, 2023 that will close this issue
@nils-a
Copy link
Member

nils-a commented Aug 23, 2023

@LoveDuckie I think I found the problem - something in the way the icons were loaded in the settings pages.

You wouldn't have the cycles to check out #351 and take it for a spin, would you? 😉

nils-a added a commit to nils-a/cake-rider that referenced this issue Aug 26, 2023
nils-a added a commit to nils-a/cake-rider that referenced this issue Aug 26, 2023
This is probably due to the change in UI on the intellij-side.
It seems the builtin add/remove icons were removed and replaced by new
ones. These needed a different kind of "loading".
nils-a added a commit that referenced this issue Aug 26, 2023
(#325) bumped rider version to 2023.1
@nils-a
Copy link
Member

nils-a commented Aug 26, 2023

I have made a preview version available in the beta chanel for everyone to test.

@LoveDuckie
Copy link

Hey @nils-a ! Thanks for pushing that out. The version appears to be working on the 2023 version of Rider that I'm using.

I just wanted to say that I've noticed that the same task will appear multiple times (one per .cs file) in the "Tasks" panel for the extension, if the derived Cake FrostingTask type is partially defined (i.e. partial) in multiple .cs files. I can open a new ticket for this if you like. Not sure if this is existing behaviour before the 2023 fix.

@nils-a
Copy link
Member

nils-a commented Aug 31, 2023

@LoveDuckie yes, I'd appreciate it if you could open a new issue.
(That way I won't forget about it 😬)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants