Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget download location #30

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

frozenskys
Copy link
Contributor

Adds advanced settings to fix Issue #4 by allowing nuget to be downloaded from an alternate file\web location and\or use an alternate feed for initial cake\tool installation.

screenshot_2

Not sure about your naming conventions, etc. so have made a best guess.

@dnfclas
Copy link

dnfclas commented Oct 19, 2016

Hi @frozenskys, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Oct 27, 2016

@frozenskys, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@frozenskys
Copy link
Contributor Author

Need to update documentation as mentioned in Issue #31

@frozenskys
Copy link
Contributor Author

@gep13 @devlead Any idea how we can test this? I've only got an on prem TFS vNext install that I can test with, and I haven't seen any example xunit style tests for build tasks. How did you test the original release?

@gep13
Copy link
Member

gep13 commented Oct 31, 2016

@frozenskys we have an internal documented process on how to test out the VSTS extension. I would just need to find some cycles in order to test it out. I will try to make some time for this.

@frozenskys
Copy link
Contributor Author

@gep13 Cool - I'll try and smoke test it on my VM tonight, as that will give me an early view of anything that's broken - but I find TFS '15' is way more tolerant of broken extensions than TFS 2015.3

@frozenskys
Copy link
Contributor Author

Added some fixes for the using the build agent nuget.exe - in order to use this when actually running the cake script rather than from the task, we need to copy nuget.exe into the cake tool folder.

@rfvgyhn
Copy link

rfvgyhn commented Dec 15, 2016

Any word on getting this merged?

@fleed
Copy link

fleed commented Jan 11, 2017

when will this change be published? I'm currently having problems running build on VSTS because of the nuget version.

@StevenWolfe
Copy link

StevenWolfe commented Feb 11, 2017

@frozenskys is there anything I can lend a hand with? We just migrated to VSO and can't run Cake due to the requirement for NuGet 3.0+, so we're falling back to running the build.ps1 via a Powershell Task--but would really like to plug directly into Cake ASAP.

Thanks!

@trailmax trailmax mentioned this pull request Feb 20, 2017
@jnm2
Copy link

jnm2 commented Mar 10, 2017

My company needs NuGet v4.0.

Copy link
Member

@agc93 agc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

- Including option to use build agent's copy of nuget.exe
@agc93 agc93 merged commit f7eb332 into cake-build:develop Mar 14, 2017
@agc93
Copy link
Member

agc93 commented Mar 14, 2017

Thanks very much @frozenskys for this awesome contribution! Your changes have now been merged and will be included in the next release of the VSTS extension.

@frozenskys frozenskys deleted the nuget-download-location branch March 14, 2017 21:01
@mmisztal1980
Copy link

Is this changeset released to VSTS yet?

@gep13
Copy link
Member

gep13 commented Mar 19, 2017

@mmisztal1980 said...
Is this changeset released to VSTS yet?

No, this hasn't been deployed yet. I believe we are on the cusp of doing it though. @agc93 can you confirm?

@mmisztal1980
Copy link

@gep13 cheers Gary.

@saberone
Copy link

Any news on this being deployed to vsts? And if not is there a workaround to make the Xunit tests run in VSTS and report the results?

@devlead
Copy link
Member

devlead commented Mar 28, 2017

@agc93 working on getting it out as soon as possible, it's mostly done, but there's a little ceremony left and little spare time to do it 😉

@VictorioBerra
Copy link

@frozenskys Since this is now out, can you please update your review? https://marketplace.visualstudio.com/items?itemName=cake-build.cake&ssr=false#overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet