Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotNetCoreRestore: dotnet restore no longer supports globbing #1111

Closed
luisgoncalves opened this issue Jul 25, 2016 · 3 comments · Fixed by #3675
Closed

DotNetCoreRestore: dotnet restore no longer supports globbing #1111

luisgoncalves opened this issue Jul 25, 2016 · 3 comments · Fixed by #3675
Assignees
Projects
Milestone

Comments

@luisgoncalves
Copy link
Contributor

luisgoncalves commented Jul 25, 2016

As pointed here by @mmisztal1980, dotnet restore no longer supports globbing on the root parameter. The XML docs on DotNetCoreRestore are OK, but the example shows a string with a globbing pattern. I also came across this problem and an issue wasn't created yyet.

@patriksvensson suggested that the root parameter on DotNetCoreRestore could become a DirectoryPath. However, on dotnet restore it actually can be a list of project.json, global.json or root directory.

  • Is there any type on cake that can represent both files and directory paths?
  • Maybe we could have a params argument?
  • Or maybe we can assume the common use case, which I think will be a root directory for search, as Patrick suggested.
@luisgoncalves luisgoncalves changed the title DotNetCoreRestore no longer supports globbing DotNetCoreRestore: dotnet restore no longer supports globbing Jul 25, 2016
@mmisztal1980
Copy link

I believe the same applies to dotnet test

@devlead
Copy link
Member

devlead commented Oct 21, 2016

@andycmaj Is this related to your issue #985?

@pascalberger pascalberger added this to the Next Major Candidate milestone Oct 11, 2021
@augustoproiete augustoproiete self-assigned this Oct 11, 2021
@pascalberger pascalberger added this to To do in 2.0.0 via automation Oct 11, 2021
@pascalberger pascalberger moved this from To do to In progress in 2.0.0 Oct 14, 2021
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Nov 6, 2021
2.0.0 automation moved this from In progress to Done Nov 6, 2021
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment