Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use working directory instead if initial script path for resolving tools directory in NuGetLoadDirectiveProvider #1957

Closed
bjorkstromm opened this issue Dec 17, 2017 · 0 comments
Closed

Use working directory instead if initial script path for resolving tools directory in NuGetLoadDirectiveProvider #1957

bjorkstromm opened this issue Dec 17, 2017 · 0 comments
Assignees
@bjorkstromm
Labels
Bug
Milestone
v0.24.0

Comments

@bjorkstromm
Copy link
Member

See cake-build/bakery#89 (comment)

Changing line

cake/src/Cake.NuGet/NuGetLoadDirectiveProvider.cs

Line 56 in 39520c3

var toolPath = GetToolPath(context.Root.GetDirectory());

to var toolPath = GetToolPath(_environment.WorkingDirectory); should result in exact same behaviour in Cake, since working directory is set to initial script´s directory here:

cake/src/Cake.Core/Scripting/ScriptRunner.cs

Line 128 in 75c6845

_environment.WorkingDirectory = scriptPath.GetDirectory();

PR incoming....
@bjorkstromm bjorkstromm added this to the v0.24.0 milestone Dec 17, 2017
@bjorkstromm bjorkstromm self-assigned this Dec 17, 2017
bjorkstromm added a commit to bjorkstromm/cake that referenced this issue Dec 17, 2017
@bjorkstromm
(cake-buildGH-1957) Use working directory instead if initial script p…
dbeb0d1 
…ath for resolving tools directory

- Fixes cake-build#1957
@bjorkstromm bjorkstromm mentioned this issue Dec 17, 2017
Merged
devlead pushed a commit to bjorkstromm/cake that referenced this issue Dec 21, 2017
@bjorkstromm @devlead
(cake-buildGH-1957) Use working directory instead if initial script p…
4877c8b 
…ath for resolving tools directory

- Fixes cake-build#1957
devlead added a commit that referenced this issue Dec 21, 2017
@devlead
Merge branch 'mholo65-feature/GH-1957' into develop
51ec61c 
* mholo65-feature/GH-1957:
  (GH-1957) Use working directory instead if initial script path for resolving tools directory
CRuppert pushed a commit to CRuppert/cake that referenced this issue Jan 23, 2018
@bjorkstromm @CRuppert
(cake-buildGH-1957) Use working directory instead if initial script p…
f4e1aa1 
…ath for resolving tools directory

- Fixes cake-build#1957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjorkstromm bjorkstromm

Labels
Bug
Projects
None yet
Milestone
v0.24.0
Development

No branches or pull requests
1 participant
@bjorkstromm