New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use working directory instead if initial script path for resolving tools directory in NuGetLoadDirectiveProvider #1957

Closed
mholo65 opened this Issue Dec 17, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@mholo65
Member

mholo65 commented Dec 17, 2017

See cake-build/bakery#89 (comment)

Changing line

var toolPath = GetToolPath(context.Root.GetDirectory());

to var toolPath = GetToolPath(_environment.WorkingDirectory); should result in exact same behaviour in Cake, since working directory is set to initial script´s directory here:
_environment.WorkingDirectory = scriptPath.GetDirectory();

PR incoming....

@mholo65 mholo65 added the Bug label Dec 17, 2017

@mholo65 mholo65 added this to the v0.24.0 milestone Dec 17, 2017

@mholo65 mholo65 self-assigned this Dec 17, 2017

mholo65 added a commit to mholo65/cake that referenced this issue Dec 17, 2017

devlead added a commit to mholo65/cake that referenced this issue Dec 21, 2017

devlead added a commit that referenced this issue Dec 21, 2017

Merge branch 'mholo65-feature/GH-1957' into develop
* mholo65-feature/GH-1957:
  (GH-1957) Use working directory instead if initial script path for resolving tools directory

CRuppert added a commit to CRuppert/cake that referenced this issue Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment