Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitting debug information should be done regardless of --debug switch #2708

Closed
devlead opened this issue Feb 1, 2020 · 1 comment · Fixed by #2709
Closed

Emitting debug information should be done regardless of --debug switch #2708

devlead opened this issue Feb 1, 2020 · 1 comment · Fixed by #2709
Assignees
Labels
Milestone

Comments

@devlead
Copy link
Member

@devlead devlead commented Feb 1, 2020

Currently Roslyn WithEmitDebugInformation(bool) is based on if Cake is executed in debug mode.

With older versions of Roslyn we still got line numbers on exceptions, that's no longer the case, so WithEmitDebugInformation should always be true as the benefits outway the costs. Trouble shooting scripts without line numbers is really tedious.

@devlead devlead added the Improvement label Feb 1, 2020
@devlead devlead added this to the v0.37.0 milestone Feb 1, 2020
@devlead devlead self-assigned this Feb 1, 2020
devlead added a commit to devlead/cake that referenced this issue Feb 1, 2020
* Fixes cake-build#2708
devlead added a commit to devlead/cake that referenced this issue Feb 1, 2020
* Fixes cake-build#2708
@devlead devlead closed this in #2709 Feb 1, 2020
devlead added a commit that referenced this issue Feb 1, 2020
GH2708: Always emit debug information
@cake-build-bot

This comment has been minimized.

Copy link

@cake-build-bot cake-build-bot commented Feb 1, 2020

🎉 This issue has been resolved in version v0.37.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.