Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error output in 1.0 preview #2861

Closed
patriksvensson opened this issue Sep 22, 2020 · 3 comments · Fixed by #2916
Closed

Fix error output in 1.0 preview #2861

patriksvensson opened this issue Sep 22, 2020 · 3 comments · Fixed by #2916
Assignees
@devlead
Labels
Bug
Projects
1.0.0
Milestone
v1.0.0

Comments

@patriksvensson
Copy link
Member

Error output looks strange in some cases:

image
@patriksvensson patriksvensson added this to the v1.0.0 milestone Sep 22, 2020
@pascalberger pascalberger added this to To do in 1.0.0 Oct 15, 2020
@devlead
Copy link
Member

devlead commented Oct 21, 2020

For reference, this is how it used to look

PATH_TO_SCRIPTbuild.cake:0: Could not find script 'PATH_TO_SCRIPTbuild.cake'.
Error: Errors occurred while analyzing script.

this is how it looks in develop now


Error: Bootstrapping failed for 'PATH_TO_SCRIPTbuild.cake'.
build.cake, line #0: Could not find script
'PATH_TO_SCRIPTbuild.cake'.

@cake-build/cake-team How do we want it do look?

@patriksvensson
Copy link
Member Author

@devlead Going to add an error handler in the CLI lib so we can control this ourselves.

devlead added a commit to devlead/cake that referenced this issue Oct 25, 2020
@devlead
(cake-buildGH-2861) Restore pre 1.0 error logging
3a85b8c 
* fixes cake-build#2861
@devlead devlead mentioned this issue Oct 25, 2020
Merged
@pascalberger pascalberger moved this from To do to In progress in 1.0.0 Oct 25, 2020
devlead added a commit to devlead/cake that referenced this issue Oct 25, 2020
@devlead
(cake-buildGH-2861) Restore pre 1.0 error logging
5869826 
* fixes cake-build#2861
@devlead devlead assigned devlead and unassigned patriksvensson Oct 25, 2020
devlead added a commit to devlead/cake that referenced this issue Oct 25, 2020
@devlead
(cake-buildGH-2861) Restore pre 1.0 error logging
ca80362 
* fixes cake-build#2861
devlead added a commit to devlead/cake that referenced this issue Oct 26, 2020
@devlead
(cake-buildGH-2861) Restore pre 1.0 error logging
f676881 
* fixes cake-build#2861
devlead added a commit to devlead/cake that referenced this issue Oct 28, 2020
@devlead
(cake-buildGH-2861) Restore pre 1.0 error logging
0e376d9 
* fixes cake-build#2861
gep13 added a commit that referenced this issue Oct 28, 2020
@gep13
Merge pull request #2916 from devlead/feature/gh-2861
6c2489c 
GH2861: Restore pre 1.0 error logging
@pascalberger pascalberger moved this from In progress to Done in 1.0.0 Oct 28, 2020
@devlead devlead mentioned this issue Nov 5, 2020
Closed
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devlead devlead

Labels
Bug
Projects
No open projects
1.0.0
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

GH2861: Restore pre 1.0 error logging devlead/cake
3 participants
@patriksvensson @devlead @cake-build-bot