Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option --target has wrong documentation in --help #2868

Closed
nils-a opened this issue Sep 29, 2020 · 7 comments
Closed

option --target has wrong documentation in --help #2868

nils-a opened this issue Sep 29, 2020 · 7 comments

Comments

@nils-a
Copy link
Member

nils-a commented Sep 29, 2020

What You Are Seeing?

Current help shows:

    --target <TARGET>    Target task to invoke. Script must support this explicitly.

which in fact does not work.

It should be changed to

    --target=value    Target task to invoke. Script must support this explicitly.

which would work (and also look a bit more like the next line..)

What is Expected?

That the options, as given in --help work.

What version of Cake are you using?

             +##   #;;'
             #;;#  .+;;;;+,
             '+;;#;,+';;;;;'#.
             ++'''';;;;;;;;;;# ;#;
            ##';;;;++'+#;;;;;'.   `#:
         ;#   '+'';;;;;;;;;'#`       #.
      `#,        .'++;;;;;':..........#
    '+      `.........';;;;':.........#
   #..................+;;;;;':........#
   #..................#';;;;;'+''''''.#
   #.......,:;''''''''##';;;;;'+'''''#,
   #''''''''''''''''''###';;;;;;+''''#
   #''''''''''''''''''####';;;;;;#'''#
   #''''''''''''''''''#####';;;;;;#''#
   #''''''''''''''''''######';;;;;;#'#
   #''''''''''''''''''#######';;;;;;##
   #''''''''''''''''''########';;;;;;#
   #''''''''''''++####+;#######';;;;;;#
   #+####':,`             ,#####';;;;;;'
                              +##'''''+.
   ___      _          ___       _ _     _
  / __\__ _| | _____  / __\_   _(_) | __| |
 / /  / _` | |/ / _ \/__\// | | | | |/ _` |
/ /___ (_| |   <  __/ \/  \ |_| | | | (_| |
\____/\__,_|_|\_\___\_____/\__,_|_|_|\__,_|

                             Version 0.38.5+Branch.main.Sha.cd4e6581b59770bda903da38d155f309f34e0e00
                       Running on .NET Core

Are you running on a 32 or 64 bit system?

64bit

What environment are you running on? Windows? Linux? Mac?

Windows

Are you running on a CI Server? If so, which one?

No

How Did You Get This To Happen? (Steps to Reproduce)

❯ dotnet cake --target Default
More than one build script specified.
For usage, use parameter --help

Output Log

None

@nils-a
Copy link
Member Author

nils-a commented Sep 29, 2020

This got introduced in #2605 but is now superseded by #2334 so I'm not really sure how much of a problem this really is.

@nils-a
Copy link
Member Author

nils-a commented Sep 29, 2020

@gep13 I aborted the PR. I think the real question is whether this fix is really needed. Or in other words how close is "The Version 1.0"?

@gep13
Copy link
Member

gep13 commented Sep 30, 2020

@nils-a It is certainly close... but I can't give a definitive date. Is this problem still present in the develop branch? If it is, we should fix it there before the release.

@nils-a
Copy link
Member Author

nils-a commented Sep 30, 2020

@gep13 no - the cli-help in the current development no longer shows an example of --target (part of the dicussion in #2605 was whether to show --target 'cause it's not really part of the cli)

@gep13
Copy link
Member

gep13 commented Oct 2, 2020

Gotcha, makes sense.

So, what are your thoughts here? Can this issue be closed?

@nils-a
Copy link
Member Author

nils-a commented Oct 2, 2020

I think, yes. The error exists since 0.35.0 - thats exactly a year now. I guess it can wait a week or two.

@nils-a
Copy link
Member Author

nils-a commented Oct 2, 2020

closing, as discussed. #2334 superseeds this issue.

@nils-a nils-a closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants