You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's like making 5 mistakes in a 3-letter catch... Seems no one actually tested or reviewed this properly.
There is some mess between using full and short assembly name in ScriptAssemblyResolver. For example Assembly.Load() method expects full name not a short one. Also see point 4 below.
Assembly version is ignored. This leads to possible compatibility issues when different versions of resolved assembly have breaking changes.
try-catch scope is too wide. If .resources assembly can't be loaded the Assembly.Load() throws a FileNotFoundException. Due to .resources assembly name check is inside try block after Assembly.Load() call it is never executed for .resources assembly. Additionally recursive call to AssemblyResolve() must be outside of try block since it handles exceptions on its own.
Finally the actual .resources assembly name check is always false because it is performed against short assembly name which never contains comma separators or spaces :)
The text was updated successfully, but these errors were encountered:
This issue is continuation of GH2734.
It's like making 5 mistakes in a 3-letter catch... Seems no one actually tested or reviewed this properly.
ScriptAssemblyResolver
. For exampleAssembly.Load()
method expects full name not a short one. Also see point 4 below.try-catch
scope is too wide. If.resources
assembly can't be loaded theAssembly.Load()
throws aFileNotFoundException
. Due to.resources
assembly name check is insidetry
block afterAssembly.Load()
call it is never executed for.resources
assembly. Additionally recursive call toAssemblyResolve()
must be outside oftry
block since it handles exceptions on its own..resources
assembly name check is alwaysfalse
because it is performed against short assembly name which never contains comma separators or spaces :)The text was updated successfully, but these errors were encountered: