Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: CopyFile logs incorrect targetFilePath #486

Closed
jrnail23 opened this issue Nov 4, 2015 · 1 comment
Closed

BUG: CopyFile logs incorrect targetFilePath #486

jrnail23 opened this issue Nov 4, 2015 · 1 comment
Labels
Bug
Milestone
v0.6.1

Comments

@jrnail23
Copy link
Contributor

jrnail23 commented Nov 4, 2015

The log message written by FileCopier.CopyFileCore reports the source file path as the target file path:

context.Log.Verbose("Copying file {0} to {1}", absoluteFilePath.GetFilename(), absoluteFilePath);

So the log message makes it look like the file is just getting copied to itself (although the copy actually works correctly).
jrnail23 added a commit to jrnail23/cake that referenced this issue Nov 4, 2015
@jrnail23
Closes cake-build#486: CopyFile logs incorrect targetFilePath
b7b5f62
@patriksvensson
Copy link
Member

Whoopsie. This is my fault... Sorry!

jrnail23 added a commit to jrnail23/cake that referenced this issue Nov 5, 2015
@jrnail23
Closes cake-build#486: CopyFile logs incorrect targetFilePath
3ed4531
@devlead devlead closed this as completed in 94ca297 Nov 6, 2015
devlead added a commit that referenced this issue Nov 6, 2015
@devlead
Merge pull request #487 from jrnail23/fix-copyfile-logging
af62492 
Closes #486: CopyFile logs incorrect targetFilePath
@gep13 gep13 added this to the v0.6.1 milestone Nov 26, 2015
@gep13 gep13 added the Bug label Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
v0.6.1
Development

No branches or pull requests
3 participants
@patriksvensson @jrnail23 @gep13