Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1352: add support for global namespace imports at the assembly level #1353

Merged
merged 1 commit into from
Nov 11, 2016

Conversation

kcamp
Copy link
Contributor

@kcamp kcamp commented Nov 11, 2016

This addresses GH-1352. Changes opens the CakeNamespaceImportAttribute up to be applied at the assembly level and extends the logic in ScriptAliasFinder to import namespaces declared for import at the assembly level.

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , I've rebased your branch against latest develop and will merge when CI's done.

@devlead devlead merged commit db6cbba into cake-build:develop Nov 11, 2016
@devlead
Copy link
Member

devlead commented Nov 11, 2016

@kcamp your changes have now been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants