GH1363: Wixheat pog fix #1360
GH1363: Wixheat pog fix #1360
Conversation
|
@gep13 Does this need an issue? I haven't gotten my head around that yet... |
|
@jnm2 yes. Ideally, you would have created the issue first, as per the contribution guidelines', and then implemented the PR. |
|
@jnm2 did you create an issue for this PR? |
|
Some time has gone by. Should I rebase? |
Apologies, all of us have been snowed under lately, and as a result, we haven't had a chance to look at some of the open PR's that we have. Rest assured, we will be getting to them though. As a general rule, keeping a PR up to date, and in a state where it can be merged certainly helps with the review process, and it can go a long way to getting your PR merged in sooner, as there isn't that back/forth required between reviewer and contributor. This is not expected to happen though, but if you are happy to rebase, then I would say go for it 👍 |
jnm2
force-pushed
the
wixheat-pog-fix
branch
2 times, most recently
from
beb87df
to
ca0a808
Compare
devlead
force-pushed
the
wixheat-pog-fix
branch
4 times, most recently
from
ecc7a29
to
259bc7c
Compare
* Fixed misspell 'satallites', broken parameter * Fixed -pog case-sensitivity, broken parameter * Fixed -pog colon followed by space, broken parameter
gep13
force-pushed
the
wixheat-pog-fix
branch
from
259bc7c
to
31717a4
Compare
|
@jnm2 thank you very much for your contribution! Your changes have now been merged, and will be included in the next release of Cake. |
Fixes three issues, each of which completely prevented the parameter from working (at least with WiX 3.10):
-pog: xcauses Heat to not associatexwith-pogand instead sets-pogto an empty string, giving:-pog x.-pog binariescauseserror HEAT5301 : Invalid project output group: binaries., whereas-pog Binariesworks. All output group names were capitalized.Satallitesis also not recognized by Heat since it is misspelled. I also renamed the enum which is a breaking change to anyone using that value. (I suspect that number is negligible due to the fact that the parameter cannot currently be used without erroring Heat.)