GH1363: Wixheat pog fix #1360

Merged
merged 1 commit into from Jan 29, 2017

Projects

None yet

3 participants

@jnm2
Contributor
jnm2 commented Nov 14, 2016 edited

Fixes three issues, each of which completely prevented the parameter from working (at least with WiX 3.10):

  • -pog: x causes Heat to not associate x with -pog and instead sets -pog to an empty string, giving:
    warning HEAT1108 : The command line switch 'pog:' is deprecated. Please use 'pog' instead.
    error HEAT5301 : Invalid project output group: .
    
    Since the colon is deprecated anyway, I changed it simply to -pog x.
  • -pog binaries causes error HEAT5301 : Invalid project output group: binaries., where as -pog Binaries works. All output group names were capitalized.
  • Satallites is also not recognized by Heat since it is misspelled. I also renamed the enum which is a breaking change to anyone using that value. (I suspect that number is negligible due to the fact that the parameter cannot currently be used without erroring Heat.)
@jnm2
Contributor
jnm2 commented Nov 14, 2016

@gep13 Does this need an issue? I haven't gotten my head around that yet...

@gep13
Member
gep13 commented Nov 14, 2016

@jnm2 yes. Ideally, you would have created the issue first, as per the contribution guidelines', and then implemented the PR.

@gep13
Member
gep13 commented Dec 6, 2016

@jnm2 did you create an issue for this PR?

@jnm2
Contributor
jnm2 commented Dec 6, 2016

@gep13 Yes, #1363

@gep13 gep13 changed the title from Wixheat pog fix to GH1363: Wixheat pog fix Dec 6, 2016
@jnm2
Contributor
jnm2 commented Dec 29, 2016

Some time has gone by. Should I rebase?

@gep13
Member
gep13 commented Dec 29, 2016

@jnm2 said...
Some time has gone by. Should I rebase?

Apologies, all of us have been snowed under lately, and as a result, we haven't had a chance to look at some of the open PR's that we have. Rest assured, we will be getting to them though.

As a general rule, keeping a PR up to date, and in a state where it can be merged certainly helps with the review process, and it can go a long way to getting your PR merged in sooner, as there isn't that back/forth required between reviewer and contributor. This is not expected to happen though, but if you are happy to rebase, then I would say go for it ๐Ÿ‘

@jnm2 @gep13 jnm2 Wixheat pog fix
* Fixed misspell 'satallites', broken parameter
* Fixed -pog case-sensitivity, broken parameter
* Fixed -pog colon followed by space, broken parameter
31717a4
@gep13
gep13 approved these changes Jan 29, 2017 View changes

LGTM!

@gep13 gep13 merged commit 2e46585 into cake-build:develop Jan 29, 2017

4 checks passed

CodeFactor 1 issue fixed.
Details
ci/bitrise/7a9d707b00881436/pr Passed - OSX Cake
Details
ci/bitrise/b811c91a26b1ea80/pr Passed - Ubuntu Cake
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@gep13
Member
gep13 commented Jan 29, 2017

@jnm2 thank you very much for your contribution! Your changes have now been merged, and will be included in the next release of Cake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment