GH1533: Updated DotNetCoreBuild inline with Tooling v1.0

[JonCubed]

• Removed settings that are no longer valid, if you prefer for them to be marked as obsolete instead let me know.
• Updated unit tests

See #1533 for more info

[dnfclas]

@JonCubed,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

[devlead]

We should add a string Version { get; set; } too, equivalent to

 ArgumentCustomization = arg=>arg.Append(string.Concat("/p:Version=", semVersion)),

We should also add an

public IDictionary<string, IList<string>> Properties => _properties;

To support MSBuild properties without ArgumentCustomization, similar too MSBuildSettings.Properties

We should also add an

public ISet<string> Targets { get; }

Running dotnet msbuild -h looks like it support most MSBuild so future refactoring could be to see what we have common between the .NET Core CLI and MSBuild alias.

[devlead]

Maybe version could be something common, know dotnet pack accepts & should have it too (haven't tested all yet but probably publish too).

[patriksvensson]

@devlead Should we really add Version now? Isn't it better to wait until the API settled a little bit? I would rather see MSBuild properties first.

If we add version we should add support for AssemblyVersion and FileVersion as well.

[JonCubed]

I was planning to add VersionPrefix after all the current tasks are done, along with Properties. I don't think we should use Version, I think it gets overridden in some situations unexpectedly and doesn't work with VersionSuffix.

@patriksvensson if my memory is correct, when I was testing using VersionPrefix with the build command acted as AssemblyVersion

[devlead]

@JonCubed your changes have been merged, thanks for your contribution 👍