GH787: Enhance NuGet dependency handling. #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bjorkstromm
commented
Sep 28, 2017
bjorkstromm
commented
- Fixes Reference NuGet dependencies installed via the #addin directive #787
- Don't share project. Only share Gather Cache.
- Use DependencyBehavior.Ignore by default. Only set Lowest if load dependencies is set. This way we wont install unneccessary packages and cache gathering is faster.
|
@Redth are you also interested in reviewing? This addresses the shared |
patriksvensson
approved these changes
Sep 29, 2017
| { | ||
| if (type == PackageType.Addin) | ||
| { | ||
| return package.ShouldLoadDependencies(_config) ? |
There was a problem hiding this comment.
You could change this to
if(package.ShouldLoadDependencies(_config))
{
return DependencyBehavior.Lowest;
}since the default behavior is to ignore dependencies by exiting the scope. Just a personal preference of course. Do as you wish 😄
|
LGTM! |
- Fixes cake-build#787 - Don't share project. Only share Gather Cache. - Use DependencyBehavior.Ignore by default. Only set Lowest if load dependencies is set. This way we wont install unneccessary packages and cache gathering is faster.
devlead
force-pushed
the
feature/GH-787
branch
from
c7471fc
to
c6cfe2f
Compare
devlead
approved these changes
Sep 30, 2017
|
@mholo65 your changes have been merged, thanks for your contribution 👍 |
|
And how to use that feature? I still have ICSharpCode.SharpZipLib, Version=0.86.0.518 not resolved. |
|
The nuget optin configuration is documented here: |
This was referenced Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.