Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH74: Adds MSpec support #1873

Merged
merged 1 commit into from Oct 22, 2017
Merged

GH74: Adds MSpec support #1873

merged 1 commit into from Oct 22, 2017

Conversation

holytshirt
Copy link
Contributor

This adds support for MSpec unit tests

  • Support NET4 and X86.
  • Doesn't support NET2 (assuming no one uses it anymore).
  • The mspec console currently doesn't support dotnet core.

@dnfclas
Copy link

dnfclas commented Oct 11, 2017

@holytshirt,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@gep13 gep13 changed the title Adds MSpec support #74 GH74: Adds MSpec support Oct 11, 2017
@@ -0,0 +1,22 @@
using System.Collections.Generic;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the license header here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dnfclas
Copy link

dnfclas commented Oct 11, 2017

@holytshirt, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@holytshirt
Copy link
Contributor Author

holytshirt commented Oct 11, 2017 via email

@holytshirt
Copy link
Contributor Author

holytshirt commented Oct 11, 2017 via email

@holytshirt
Copy link
Contributor Author

I can't see why the OSX Cake build has failed, says I'm "Not authorized." I signed up to bitrise but still can't seem the error

@patriksvensson
Copy link
Member

@holytshirt CI failed to restore packages. I've restarted it for you.

@gep13
Copy link
Member

gep13 commented Oct 22, 2017

Relates to #74

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 23c6346 into cake-build:develop Oct 22, 2017
@gep13
Copy link
Member

gep13 commented Oct 22, 2017

@holytshirt your changes have been merged, thanks for your contribution 👍

@holytshirt
Copy link
Contributor Author

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants