New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH74: Adds MSpec support #1873
GH74: Adds MSpec support #1873
Conversation
@holytshirt, It will cover your contributions to all .NET Foundation-managed open source projects. |
@@ -0,0 +1,22 @@ | |||
using System.Collections.Generic; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the license header here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@holytshirt, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
done
…On 11 October 2017 at 15:52, Gary Ewan Park ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In src/Cake.Common/Tools/MSpec/MSpecRunnerUtilities.cs
<#1873 (comment)>:
> @@ -0,0 +1,22 @@
+using System.Collections.Generic;
Can you add the license header here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1873 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFgFOjO33rSyPT-nV1kppWg-QHAjJsVks5srNY3gaJpZM4P1lsT>
.
|
Pleasure doing business with you 😊
From: Gary Ewan Park
Sent: 11 October 2017 16:06
To: cake-build/cake
Cc: Toby Henderson; Mention
Subject: Re: [cake-build/cake] GH74: Adds MSpec support (#1873)
@gep13 approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I can't see why the OSX Cake build has failed, says I'm "Not authorized." I signed up to bitrise but still can't seem the error |
@holytshirt CI failed to restore packages. I've restarted it for you. |
Relates to #74 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@holytshirt your changes have been merged, thanks for your contribution 👍 |
Awesome thanks! |
This adds support for MSpec unit tests