GH1692: Log more diagnostics from Roslyn. #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bjorkstromm
commented
Dec 17, 2017
bjorkstromm
commented
- Fixes Log script compilation warnings and other diagnostics #1692
gep13
requested changes
Dec 18, 2017
| @@ -96,10 +96,30 @@ public void Execute(Script script) | |||
| var compilation = roslynScript.GetCompilation(); | |||
| var diagnostics = compilation.GetDiagnostics(); | |||
|
|
|||
| if (diagnostics.Any(d => d.Severity == DiagnosticSeverity.Error)) | |||
| var errors = new List<Diagnostic>(); | |||
There was a problem hiding this comment.
@mholo65 am I missing something here, or are you never adding anything to errors?
There was a problem hiding this comment.
Oh, minor issue happened during refactoring. Nice catch!
|
@mholo65 could you address feedback and rebase against latest develop? |
devlead
force-pushed
the
feature/GH-1692
branch
from
dad9583
to
3d283b4
Compare
|
@mholo65 your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.