Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Newtonsoft.Json nuget package version to latest stable #2597

Conversation

mpritch599
Copy link
Contributor

Using the * notation for version spec (latest stable version).
This will bring in the latest stable version at compile time, and reference that.
Related to #2116, which is not resolved on dotnet core, and causes exceptions when referencing Newtonsoft.Json.

Using the * notation for version spec (latest stable version).
This will bring in the latest stable version at compile time, and reference that.
Related to cake-build#2116, which is not resolved on dotnet core, and causes exceptions when referencing Newtonsoft.Json.
@dnfclas
Copy link

dnfclas commented Aug 15, 2019

CLA assistant check
All CLA requirements met.

@gep13
Copy link
Member

gep13 commented Aug 17, 2019

@pritchums thank you for taking the time to raise this PR, however, at this time, I don't think we will be able to accept this contribution.

One of the things that we strongly recommend when using Cake itself is to always pin to a specific version of Cake and any addins/tools/modules that you are using. Doing this, means that you have the most repeatable/reliable/resilient build possible, as upstream changes to anything doesn't have an impact on your own build.

We follow this same advice in our own build, and as such, using the wildcard to always pull in the latest stable version of this PackageReference violates that philosophy since one build one day might succeed, and the same build the next might fail, due to upstream change.

My suggestion would be to raise an issue discussing the specific problem that you are facing, so that we can agree a path forward.

@gep13 gep13 closed this Aug 17, 2019
@mpritch599 mpritch599 deleted the UpdatingNewtonsoftJsonToLatest branch August 19, 2019 07:42
@mpritch599
Copy link
Contributor Author

Thanks @gep13 - will definitely make sure I raise an issue first next time!

Accept your point on the use of "*" to specify the version - I did erm and err about that, but should have discussed first.

I've raised #2606 to cover the underlying issue. I believe the fix is pretty much what is in this PR, albeit with specifying the version explicitly to 12.0.2. I can confirm this resolves the underlying issue on dotnet core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants