Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH2833: Add implicit bootstrapping of modules #2849

Merged
merged 1 commit into from
Sep 14, 2020
Merged

GH2833: Add implicit bootstrapping of modules #2849

merged 1 commit into from
Sep 14, 2020

Conversation

patriksvensson
Copy link
Member

Closes #2833

@gep13 gep13 changed the title Add implicit bootstrapping of modules GH2833: Add implicit bootstrapping of modules Sep 9, 2020
@devlead devlead requested a review from a team September 9, 2020 08:30
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet-cake.exe ./build.cake --bootstrap should not execute script.

@patriksvensson
Copy link
Member Author

@cake-build/cake-team Ready for review

@patriksvensson patriksvensson marked this pull request as ready for review September 9, 2020 11:49
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken this for a spin, afaik as I can see it works as intended i.e.

Test-Path .\tools\modules
.\tools\dotnet-cake.exe --target=Clean
Test-Path .\tools\modules

outputs

False
Tool GitVersion.Tool is already installed, with required version.
Tool SignClient is already installed, with required version.
Tool GitReleaseManager.Tool is already installed, with required version.

----------------------------------------
Setup
----------------------------------------
Calculating Semantic Version
Calculated Semantic Version: 1.0.0-GH-2833-0001
Building version 1.0.0-GH-2833-0001 of Cake (Release, Clean) using version 1.0.0.0 of Cake. (IsTagged: False)

========================================
Clean
========================================

----------------------------------------
Teardown
----------------------------------------
Starting Teardown...
Finished running tasks.

Task                          Duration
--------------------------------------------------
Setup                         00:00:01.0869588
Clean                         00:00:00.1628303
Teardown                      00:00:00.0054472
--------------------------------------------------
Total:                        00:00:01.2552363
True

First False in output = no module folder
Last True in output + that it starts = modules fetched and script executed

And running

Test-Path .\tools\modules
.\tools\dotnet-cake.exe build.cake --bootstrap
Test-Path .\tools\modules

outputs

False
True

First False in output = no module folder
Last True in output + nothing else= modules fetched but script not executed

@devlead devlead merged commit a068ac0 into cake-build:develop Sep 14, 2020
@devlead
Copy link
Member

devlead commented Sep 14, 2020

@patriksvensson your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit bootstrapping of modules
2 participants