Prefer tools with platform affinity #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitfool
changed the title
gitfool
force-pushed
the
gh3066
branch
2 times, most recently
from
7a8c140
to
2001abe
Compare
|
Ready for review. |
gitfool
force-pushed
the
gh3066
branch
2 times, most recently
from
3a6cd25
to
bf5b085
Compare
augustoproiete
force-pushed
the
gh3066
branch
from
bf5b085
to
c4a71e4
Compare
augustoproiete
approved these changes
Feb 28, 2021
|
@gitfool your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial idea to fix #3066 - sort tool exe names by "platform affinity"; using executable extension to identify Windows specific tools.
Specifically, tool exe names ending with
bat,cmdorexeextensions are assumed to be Windows tools. If the detected runtime platform is also Windows then such tools will be prioritized, otherwise they will be deprioritized. In both cases their relative order will be preserved.With this fix, tool authors won't have to deal with environmental specific hacks like MihaMarkic/Cake.Docker#84.