Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3081: Add netcoreapp3.1 target to Cake #3139

Conversation

augustoproiete
Copy link
Member

Tests already target netcoreapp3.1 so changes needed there.


Closes #3081

@devlead
Copy link
Member

devlead commented Feb 13, 2021

In phone, but this probably relates to / maybe duplicates #2873

@augustoproiete
Copy link
Member Author

@devlead It's definitely related, but #2873 is breaking and doesn't seem we'll merge until Cake v2.0. This PR is additive, only to help devs that don't have netcoreapp3.1 and higher only, and don't want to deal with roll-forward.

@devlead
Copy link
Member

devlead commented Feb 13, 2021

@augustoproiete back at computer, agreed 👍

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 04098aa into cake-build:develop Feb 13, 2021
@devlead
Copy link
Member

devlead commented Feb 13, 2021

@augustoproiete your changes have been merged, thanks for your contribution 👍

@augustoproiete augustoproiete deleted the add-netcoreapp-31-target-to-cake-tool branch February 13, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add netcoreapp3.1 target to Cake
2 participants