GH-1616: Better error message for interdependent tasks

[norpache]

• Error message was changed. But it feels kind of awkward since we seams to be in "low level" graph code but we want a user friendly "high" level message.
• Fixes Error message on circular references leads to poor developer experience #1616
• Added information was put on another line to maintain backwards compatibility with old message.

[dnfadmin]

All CLA requirements met.

[norpache]

The case where a task depends on itself could probably also use a better message (Error "Reflexive edges in graph are not allowed."). Let me know if you want it changed in another PR.

[augustoproiete]

@norpache Thanks for the PR!

I think you're spot on in the sense that we're trying to get a user-friendly message from a low-level API.

Perhaps the way to go about this, would be to throw custom graph exceptions as needed (e.g. CakeGraphCircularReferenceException) from the low-level code including the details that you'd need to craft a user-friendly message (e.g. edge names, etc.) that can bubble up the stack and be caught closer to the UI, and then a CakeException can be thrown with a friendly message, with the custom exception as the innerException.

@cake-build/cake-team What do you think?

[p10tyr]

Just migrated everything to Cake.Frosting and got this message.. Was scratching my head but now i know there is a circular dependency... somewhere.. because all tasks are throwing this message.

[augustoproiete]

LGTM

[augustoproiete]

@norpache your changes have been merged, thanks for your contribution 👍

If you have a Twitter account and want us to give you a shout out when this gets released, let us know your Twitter handle.