GH-316: Enable Specifying Target without Switch #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow accepting Target as a positional parameter as well as a switch. Also rewrites the argument parser slightly to process all arguments, appending positions, and then process them.
|
Sorry for not responding to this until now. Will take a look at it today 😄 |
| @@ -0,0 +1,20 @@ | |||
| namespace Cake.Arguments | |||
| { | |||
| internal struct Argument | |||
There was a problem hiding this comment.
No advantage to use a struct here. Should be a class.
|
It seems to do the job, but the argument parser have become kind of complex. This was the case before the change so it's not your fault, but adding more logic to it didn't make it better 😄 I think that most of the logic could be simplified in the future by writing a proper tokenizer, but we can postpone that until later. Left some minor comments in the code. / Patrik |
|
Agreed on proper tokenizer support. This'll have to do in the meantime. |
|
Updated to address PR feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316: Allow accepting Target as a positional parameter as well as a switch.
Also rewrites the argument parser slightly to process all arguments,
appending positions, and then process them.