Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH3542: Add DotNetTool alias (synonym to DotNetCoreTool) #3584

Merged
merged 1 commit into from
Oct 13, 2021
Merged

GH3542: Add DotNetTool alias (synonym to DotNetCoreTool) #3584

merged 1 commit into from
Oct 13, 2021

Conversation

augustoproiete
Copy link
Member

DotNetCore DotNet synonym
DotNetCoreTool ➡️ 🆕 DotNetTool
DotNetCoreToolSettings ➡️ 🆕 DotNetToolSettings
DotNetCoreRollForward ➡️ 🆕 DotNetCoreRollForward
  • New DotNetTool aliases are being introduced
  • DotNetTool aliases contain the code of the existing DotNetCoreTool (rename/move)
  • Existing DotNetCoreTool aliases are forwarding calls to newly introduced DotNetTool aliases
  • New DotNetToolSettings class is being introduced
  • DotNetToolSettings class contains the code of DotNetCoreToolSettings (rename/move)
  • The previous DotNetCoreToolSettings is now empty and inherits from the new DotNetToolSettings
  • DotNetCoreRollForward is just syntactic sugar for DotNetCoreRollForward for now. In Cake v3.0.0 we can make it a proper enum or class that replaces DotNetCoreRollForward
  • Namespaces Cake.Common.Tools.DotNetCore.* have been preserved as to not introduce breaking changes
  • Unit Tests and Integration Tests remain the same, and call the old DotNetCore*** aliases, exercising the new DotNet*** aliases in the process

Closes #3542

@augustoproiete augustoproiete requested a review from a team October 11, 2021 23:01
@augustoproiete augustoproiete marked this pull request as draft October 11, 2021 23:05
@augustoproiete augustoproiete marked this pull request as ready for review October 11, 2021 23:43
devlead
devlead approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 159c786 into cake-build:develop Oct 13, 2021
@devlead devlead deleted the add-dotnet-tool-alias branch October 13, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DotNetTool alias (synonym to DotNetCoreTool)
2 participants
@augustoproiete @devlead