Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias for dotnet workload uninstall command #3860

Merged
merged 1 commit into from Aug 23, 2022

Conversation

Marusyk
Copy link
Contributor

@Marusyk Marusyk commented Apr 4, 2022

Add an alias for dotnet workload uninstall command

Fixes #3486

There is nothing to uninstall on the build servers, what integration test I should add here: https://github.com/cake-build/cake/blob/develop/tests/integration/Cake.Common/Tools/DotNetCore/DotNetCoreAliases.cake

  • Install any workload in "Cake.Common.Tools.DotNetCore.DotNetCoreAliases.Setup"
  • Add "Cake.Common.Tools.DotNetCore.DotNetCoreAliases.DotNetWorkloadInstall" and "Cake.Common.Tools.DotNetCore.DotNetCoreAliases.DotNetWorkloadUninstall" as dependent on the "DotNetWorkloadInstall"
  • DotNetWorkloadUninstall("any") with try...catch
  • Skip for now

Please review
Thank you in advance

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 255feb4 into cake-build:develop Aug 23, 2022
@devlead
Copy link
Member

devlead commented Aug 23, 2022

@Marusyk your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add alias for dotnet workload uninstall command
2 participants