Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH3878: Adds support for case sensitive OpenCover filters #3877

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

lynkx
Copy link
Contributor

@lynkx lynkx commented Apr 27, 2022

Currently, if you try to apply multiple (case-sensitive) filters (with same-ish values) in your cake script like this:

var coverageInclusionFilters = new List<string>
{
   "+[ModuleName*]*",
   "+[moduleName*]*"
};

var openCoverSettings = new OpenCoverSettings();
//rest of the code omitted for clarity

for(var inclusionFilter in coverageInclusionFilters)
{
   openCoverSettings.WithFilter(inclusionFilter);
}

It produces this kind of a filter argument value:

-filter:"+[ModuleName*]*" 

containing only the first one from the coverageInclusionFilters list from the code above.

As per https://github.com/opencover/opencover/wiki/Usage#understanding-filters
OpenCover filters are case-sensitive.

This change enables you to apply those kind of filter values.

As per https://github.com/opencover/opencover/wiki/Usage#understanding-filters OpenCover filters are case-sensitive. This change enables you to apply those kind of filter values.
@dnfadmin
Copy link

dnfadmin commented Apr 27, 2022

CLA assistant check
All CLA requirements met.

@lynkx
Copy link
Contributor Author

lynkx commented Apr 27, 2022

cc @DNikolina

@devlead devlead changed the title Adds support for case sensitive OpenCover filters GH3878: Adds support for case sensitive OpenCover filters Apr 28, 2022
@devlead devlead linked an issue Apr 28, 2022 that may be closed by this pull request
@devlead devlead enabled auto-merge April 28, 2022 14:12
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit a5e35e5 into cake-build:develop Apr 28, 2022
@devlead
Copy link
Member

devlead commented Apr 28, 2022

@lynkx your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenCover filters should be case sensitive
3 participants