Change the way assembly references are loaded. #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been using Assembly.LoadFile to load script assembly references which work great until you load an assembly where there is a dependency to a previously loaded assembly. By using Assembly.LoadFrom we make sure that assemblies are loaded properly. Closes #415
|
@patriksvensson, I'm finally getting back to some Cake stuff, and I think you're right, this shouldn't have much (if any) impact on my NuGet addin work (#373). At first I thought you might've been looking to alter the part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using Assembly.LoadFile to load script assembly references
which work great until you load an assembly where there is a
dependency to a previously loaded assembly. By using Assembly.LoadFrom
we make sure that assemblies are loaded properly.
Closes #415