Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WorkingDirectory option for running Chocolatey #520

Merged
merged 1 commit into from
Nov 25, 2015

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Nov 13, 2015

As discussed in GH-510

@gep13
Copy link
Member Author

gep13 commented Nov 13, 2015

@patriksvensson is this the implementation that you were suggesting?

@patriksvensson
Copy link
Member

@gep13 Yes, but I think it might be better to call it OutputPath (or what the corresponding name is for NuGet). This will make it an easy change if/when Chocolatey adds this option.

@patriksvensson
Copy link
Member

@gep13 Did it work?

@gep13
Copy link
Member Author

gep13 commented Nov 13, 2015

@patriksvensson said...
Did it work?

I didn't actually test it yet, wanted to make sure I was on the right path first. Also, just away to sign off for the night, so will test over the weekend.

@gep13 gep13 force-pushed the Issue-510 branch 2 times, most recently from 7c11004 to 7b1e5cf Compare November 25, 2015 21:38
@gep13
Copy link
Member Author

gep13 commented Nov 25, 2015

@patriksvensson I have fixed this up as you suggested. I have also verified that it is working by changing our own build.cake file to use that settings, rather than the previous MoveDirectory that was being used.

Think this is ready for merging, assuming CI passes.

@gep13
Copy link
Member Author

gep13 commented Nov 25, 2015

Well shite!

Of course that isn't going to work :-(

@gep13
Copy link
Member Author

gep13 commented Nov 25, 2015

@patriksvensson I have taken back out the modification of the build.cake file. Once this change is merged in, I will add it back in as a separate PR.

@patriksvensson patriksvensson merged commit b918397 into cake-build:develop Nov 25, 2015
@gep13 gep13 deleted the Issue-510 branch November 25, 2015 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants