Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Nuget.Core.dll to NuGet.Core.dll in build script #684

Merged
merged 1 commit into from Feb 21, 2016

Conversation

nathansoz
Copy link
Contributor

We were finding that NuGet.Core wasn't able to be resolved on our linux systems when using Cake because it was getting copied into the nuget package as Nuget.Core.dll. It turns out that the resolution of this file is case sensitive on linux. I believe this issue may also have been encountered by @Silvenga in issue #623

@gep13
Copy link
Member

gep13 commented Feb 11, 2016

@nathansoz thanks for the contribution! The change itself looks good.

Would it be possible to alter this PR slightly to create a new branch, and rebase the change on the develop branch, rather than have the merge in your commit history? This is as per our contributing document: https://github.com/cake-build/cake/blob/develop/CONTRIBUTING.md

Thanks!

@nathansoz
Copy link
Contributor Author

Sorry about that! I believe I've done the right thing now. Let me know if it isn't correct.

@gep13
Copy link
Member

gep13 commented Feb 21, 2016

@nathansoz this looks better. I am going to go ahead and merge this change in, this it is a relatively small change. However, for any future changes, can I please ask that you first create a branch, from develop, to do your work on, and then create the Pull Request from that branch, into cake/develop?

This makes getting changes etc done on the branch much easier. Thanks again for your contribution, we really appreciate it! 👍

@gep13 gep13 added this to the v0.9.0 milestone Feb 21, 2016
gep13 added a commit that referenced this pull request Feb 21, 2016
Change Nuget.Core.dll to NuGet.Core.dll in build script
@gep13 gep13 merged commit 2a49a13 into cake-build:develop Feb 21, 2016
@nathansoz
Copy link
Contributor Author

Ah got it. I did make a branch, but I merged it into my develop branch first. Sorry!

@gep13
Copy link
Member

gep13 commented Feb 21, 2016

@nathansoz not a problem at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants