Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Cake.Curl add-in #254

Merged
merged 1 commit into from Jan 13, 2017
Merged

Adds the Cake.Curl add-in #254

merged 1 commit into from Jan 13, 2017

Conversation

ecampidoglio
Copy link
Member

Adds Cake.Curl to the list of add-ins.

@dnfclas
Copy link

dnfclas commented Jan 13, 2017

Hi @ecampidoglio, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@ecampidoglio
Copy link
Member Author

It seems that the build is failing because Cake.Curl is flagged as a prerelease package on NuGet. I'll release a stable version later today.

@daveaglick
Copy link
Member

Prerelease is fine, you just have to add an extra flag (see https://github.com/cake-build/website/blob/develop/addins/Cake.Wyam.yml)

@gep13
Copy link
Member

gep13 commented Jan 13, 2017

@ecampidoglio did you see the above note from @daveaglick?

@ecampidoglio
Copy link
Member Author

@daveaglick @gep13 Yes, that's good to know. However, the package is already stable enough to be released as such. I could, however, just use the prerelease flag for now and remove it later once I release the stable package.

@gep13
Copy link
Member

gep13 commented Jan 13, 2017

@ecampidoglio sounds good.

@daveaglick what happens with the prerelease flag, if the latest package is not a pre-release version? Does it just give you the latest pre-release version, or the latest version?

@daveaglick
Copy link
Member

The flag just triggers the prerelease switch in the NuGet CLI. The NuGet docs say that "Allows prerelease packages to be installed." That sounds like it just uses the normal behavior while considering prerelease packages, but I haven't tested that scenario.

@devlead
Copy link
Member

devlead commented Jan 13, 2017

It'll always pick the latest version unless verion is specified, if prerelease isn't specified it'll pick latest stable.

@gep13
Copy link
Member

gep13 commented Jan 13, 2017

Sounds like @ecampidoglio might be able to give us a good use case here though. i.e. add prerelease to yml file just now, and make sure it builds. And then push new non pre-release version to NuGet.org, and see if it pulls through the latest version.

@devlead
Copy link
Member

devlead commented Jan 13, 2017

@gep13 agree 👍

@ecampidoglio
Copy link
Member Author

Happy to help 😄

Is it OK if I rewrite the commit to include the prerelease flag or you would like to have it in a different commit for historical reference? (you know, the whole true history Git debate 😉)

@gep13
Copy link
Member

gep13 commented Jan 13, 2017

@ecampidoglio rewrite is fine. 😄

@gep13
Copy link
Member

gep13 commented Jan 13, 2017

REBASE FTW!!!! :-)

@devlead devlead merged commit 8b7653d into cake-build:develop Jan 13, 2017
@devlead
Copy link
Member

devlead commented Jan 13, 2017

@ecampidoglio your changes have been merged! Thanks for contributing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants