-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Cake.Prompt #609
added Cake.Prompt #609
Conversation
@megakid before getting this merged, can you confirm whether you have spoken with the original author of Cake.Prompt before forking and pushing the NuGet package? Was there a reason that the package never made it to NuGet.org? |
I haven't spoken with the original author (I have added a comment to the 2 year old open PR on that repo) - the original fork seems pretty dead. I pretty much changed the entire csproj/targetting/method implemenation today and have also added the original fork's author as a co-author of mine. There was no reason it didn't make it to NuGet that I can see from that PR, just that it was old. |
@megakid apologies for not getting back to you sooner about this, I must have missed the notification. Thank you for explaining. Would you be interested in moving this addin into the Cake-Contrib Organisation, so that we can ensure the long term maintainability of the addin? |
/rebase |
The rebase failed:
To rebase manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/rebase develop
# Navigate to the new directory.
cd .worktrees/rebase
# Rebase and resolve the likely conflicts.
git rebase --interactive --autosquash develop
# Push the new branch state to GitHub.
git push --force
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/rebase |
@devlead @asbjornu @ecampidoglio so, I "think" I see the issue here, and why the rebase plugin isn't working as expected. The PR comes from the develop branch on the fork, not a branch on the fork, and I "think" that this is why it isn't able to rebase it. It would be good to test this again with another PR that uses a branch, before raising any issue about what is going on here. Thoughts? |
I agree that’s worth a shot. |
Absolutely. How does that happen? :) |
@megakid the entire process is documented here: The only part that I would need you to do would be the initial transfer of the repository to my GitHub account, and from there, I can move it into the Organisation. |
Transfer requested @gep13 |
@megakid I have now went through the process of adding this repository into the Cake-Contrib Organisation, and you should have received an email asking you to join. Do you use Slack? If so, can you let me know the preferred email address to send you an invite to? Also, are you on Twitter? If so, can you let me know your Twitter username? Regarding this PR.. Would you be able to raise a new PR, using a branch so that we can update it with the latest changes from the source repository? Thanks! |
My twitter is @floydy - I don't use Slack unfortunately. I'll raise a new PR :) |
No description provided.